Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distinct() now preserves order in corner cases #78

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 12, 2023

Closes #77.

@codecov-commenter
Copy link

Codecov Report

Merging #78 (837318b) into main (1c12f30) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 837318b differs from pull request most recent head 4af7c41. Consider uploading reports for the commit 4af7c41 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@          Coverage Diff          @@
##            main     #78   +/-   ##
=====================================
  Coverage   7.56%   7.57%           
=====================================
  Files        121     121           
  Lines      19112   19113    +1     
=====================================
+ Hits        1446    1447    +1     
  Misses     17666   17666           
Files Coverage Δ
R/distinct.R 74.57% <100.00%> (+0.43%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@krlmlr krlmlr merged commit 4ff5ca7 into main Nov 12, 2023
9 checks passed
@krlmlr krlmlr deleted the b-77-distinct-order branch November 12, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order preservation in distinct() wrong in corner cases
2 participants