Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deviation_estimator): parametrize which data to use #125

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Sep 7, 2023

Description

Parametrize which data to use in deviation_estimator

Related links

None

Tests performed

Added a unit test for the added function

Notes for reviewers

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda and others added 2 commits September 7, 2023 11:21
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review September 7, 2023 02:25
kminoda and others added 3 commits September 7, 2023 11:26
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 36.36% and project coverage change: +18.44% 🎉

Comparison is base (decf391) 0.93% compared to head (1b4cd9e) 19.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           tier4/universe     #125       +/-   ##
===================================================
+ Coverage            0.93%   19.38%   +18.44%     
===================================================
  Files                 261       14      -247     
  Lines               20001      552    -19449     
  Branches              368      301       -67     
===================================================
- Hits                  187      107       -80     
+ Misses              19668      370    -19298     
+ Partials              146       75       -71     
Flag Coverage Δ
differential 19.38% <36.36%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...on_estimator/include/deviation_estimator/utils.hpp 26.92% <ø> (ø)
...ls/deviation_estimator/src/deviation_estimator.cpp 7.40% <0.00%> (-0.64%) ⬇️
...estimation_tools/deviation_estimator/src/utils.cpp 22.36% <66.66%> (+1.82%) ⬆️
...tion_tools/deviation_estimator/test/test_utils.cpp 66.66% <66.66%> (ø)

... and 248 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit 123dbde into tier4/universe Sep 7, 2023
7 of 8 checks passed
@knzo25 knzo25 deleted the feat/deviation_estimator/parametrize_which_data_to_use branch June 5, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants