feat(deviation_estimator): use yaw stddev instead of max for stddev gyro #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For IMU link standard deviation, we would like to use yaw standard deviation in base_link for all the three axes.
This is because the standard deviation estimation of x and y in base_link may not be accurate especially when the data contains a motion when the people are getting on/off the vehicle, which causes the vehicle to tilt in roll and pitch. In this case, we would like to use the standard deviation of yaw axis in base_link.
For instance, the original algorithm caused a very large standard deviation for stddev_angular_*, e.g. 0.9[rad/s], possible due to the tilting motion of the vehicle when the vehicle is stopped.
With this PR, the estimated value is now around 0.006 [rad/s] for the same rosbag, which is closer to it's real standard deviation apparently from the plot.
Related links
None
Tests performed
Tested on our calibration data.
Notes for reviewers
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.