Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extrinsic_calibration_manager): rename mapping pointcloud topic for xx1 #153

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

muraki-t4
Copy link
Contributor

@muraki-t4 muraki-t4 commented Feb 14, 2024

Description

Rename mapping pointcloud topic for xx1

Related links

None

Tests performed

Launched extrinsic mapping-based calibration and confirmed that mapping and calibration has been successfull.

Notes for reviewers

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@muraki-t4 muraki-t4 marked this pull request as ready for review February 14, 2024 15:01
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@muraki-t4 muraki-t4 merged commit e4d59eb into tier4/universe Feb 15, 2024
7 of 9 checks passed
@muraki-t4 muraki-t4 deleted the fix/mapping_pointcloud_topic_name branch February 15, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants