Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: response time all #310

Merged
merged 8 commits into from
Aug 25, 2023
Merged

Conversation

rokamu623
Copy link
Contributor

@rokamu623 rokamu623 commented Jul 24, 2023

Description

As a method for calculate ResponseTime, in addition to the existing worst/best, a method is implemented to calculate the ResponseTime from all inputs (even if the outputs are the same).

image

The following APIs have been added:

  • ResponseTime.to_all_records()
    • return Records including response times for all case.
  • ResponseMapAll class
    • generate Records which is returned by ResponseTime.to_all_records().

Related links

Jira: https://tier4.atlassian.net/browse/RT2-825

Notes for reviewers

regression test of CARET_report
image

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
@rokamu623 rokamu623 marked this pull request as draft July 24, 2023 03:53
Copy link
Collaborator

@nabetetsu nabetetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it also needs to test for error cases. For example, the value of end is greater than start.

@@ -0,0 +1,138 @@
# Copyright 2021 Research Institute of Systems Planning, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think the year of the copyright is 2023.
  • Isnt't the copyright holder EMB IV?

Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
@rokamu623 rokamu623 marked this pull request as ready for review August 10, 2023 04:44
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
@rokamu623 rokamu623 self-assigned this Aug 11, 2023
@rokamu623
Copy link
Contributor Author

@emori-ctc
Please review this PR.

Copy link
Contributor

@emori-ctc emori-ctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by.

@rokamu623
Copy link
Contributor Author

@nabetetsu
Please check this PR.

Copy link
Collaborator

@nabetetsu nabetetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that the changes works fine as expected. 👍

@rokamu623 rokamu623 merged commit cf35284 into tier4:main Aug 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants