-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: response time all #310
Conversation
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it also needs to test for error cases. For example, the value of end is greater than start.
@@ -0,0 +1,138 @@ | |||
# Copyright 2021 Research Institute of Systems Planning, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think the year of the copyright is 2023.
- Isnt't the copyright holder EMB IV?
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
@emori-ctc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed by.
@nabetetsu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that the changes works fine as expected. 👍
Description
As a method for calculate
ResponseTime
, in addition to the existing worst/best, a method is implemented to calculate theResponseTime
from all inputs (even if the outputs are the same).The following APIs have been added:
ResponseTime.to_all_records()
ResponseMapAll
classResponseTime.to_all_records()
.Related links
Jira: https://tier4.atlassian.net/browse/RT2-825
Notes for reviewers
regression test of CARET_report
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.