Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add histogram api #317

Merged
merged 21 commits into from
Sep 20, 2023
Merged

feat: add histogram api #317

merged 21 commits into from
Sep 20, 2023

Conversation

emori-ctc
Copy link
Contributor

@emori-ctc emori-ctc commented Aug 24, 2023 •
edited by nabetetsu
Loading

Description

Complete the API to display the response time of a path in a histogram.
In addition, an API to display the latency of Node and Communication in a histogram will be implemented.

Related links

Jira: https://tier4.atlassian.net/browse/RT2-886

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@emori-ctc emori-ctc changed the title Add callback hist feat: Add histogram API Aug 24, 2023
@rokamu623 rokamu623 changed the title feat: Add histogram API feat: add histogram api Aug 24, 2023
@rokamu623 rokamu623 self-requested a review August 31, 2023 02:12
rokamu623
rokamu623 requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@rokamu623 rokamu623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by.
The following points should be corrected.

src/caret_analyze/plot/histogram/histogram_plot.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/histogram/histogram_plot.py Show resolved Hide resolved
src/caret_analyze/plot/histogram/histogram_plot.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/histogram/histogram_plot_factory.py Show resolved Hide resolved
src/caret_analyze/plot/histogram/histogram_plot_factory.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/histogram/histogram_plot_factory.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/plot_facade.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/visualize_lib/bokeh/bokeh.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/histogram/histogram_plot_factory.py Outdated Show resolved Hide resolved
@emori-ctc
The points raised in the review have been corrected.
f4faa59 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
@rokamu623 rokamu623 self-requested a review August 31, 2023 05:51
rokamu623
rokamu623 requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@rokamu623 rokamu623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo.

src/caret_analyze/plot/histogram/histogram_plot_factory.py Outdated Show resolved Hide resolved
@emori-ctc
rename variable
3e11290 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
@emori-ctc
The points raised in the review have been corrected.
7c5ee50 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
@emori-ctc
The points raised in the review have been corrected.
73a3549 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
@emori-ctc
The points raised in the review have been corrected.
2a6c4eb 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
rokamu623
rokamu623 requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@rokamu623 rokamu623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following revisions are requested.

src/caret_analyze/plot/histogram/histogram_plot_factory.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/histogram/histogram_plot_factory.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/histogram/histogram_plot_factory.py Outdated Show resolved Hide resolved
src/caret_analyze/plot/plot_facade.py Outdated Show resolved Hide resolved
@emori-ctc
The points raised in the review have been corrected.
6402769 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
rokamu623

This comment was marked as off-topic.

Sign in to view

rokamu623
rokamu623 previously approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@rokamu623 rokamu623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emori-ctc
The graph legend has been corrected.
15f28f1 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
@emori-ctc
The vertical axis has been changed to a probability notation.
7b09242 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
rokamu623
rokamu623 previously approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@rokamu623 rokamu623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Request an operational test.

@emori-ctc
autoware is now supported.
94b87f7 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
@emori-ctc
Removed unnecessary comment-outs.
f874ae7 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
@emori-ctc
The conflict has been resolved.
dc53eeb 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
@emori-ctc
The pytest error has been resolved.
bba9f86 
Signed-off-by: emb4 <yuki.emori@tier4.jp>
rokamu623
rokamu623 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@rokamu623 rokamu623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nabetetsu
nabetetsu approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@nabetetsu nabetetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed histogram was displayed as expected.
However, it is difficult to see when graphs overlap, so we would like to consider improvements for the future, such as devising a hover display.

image

@rokamu623 rokamu623 merged commit 943d44d into tier4:main Sep 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabetetsu nabetetsu nabetetsu approved these changes

@rokamu623 rokamu623 rokamu623 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emori-ctc @rokamu623 @nabetetsu