Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: response time worst in input #319

Merged
merged 8 commits into from
Aug 31, 2023
Merged

feat: response time worst in input #319

merged 8 commits into from
Aug 31, 2023

Conversation

rokamu623
Copy link
Contributor

@rokamu623 rokamu623 commented Aug 25, 2023 •
edited by nabetetsu
Loading

Description

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rokamu623
feat: ResponseTime.to_worst_in_input_records
ffc80d6 
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
@rokamu623
feat: test for worst in input
a278d30 
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
@rokamu623 rokamu623 requested a review from taro-yu August 25, 2023 10:15
@rokamu623 rokamu623 changed the title Feat/response time worst in input feat: response time worst in input Aug 25, 2023
@rokamu623
fix: typo
311e7ba 
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
@rokamu623
Merge branch 'main' into feat/response_time_worst_in_input
7cb323b
@rokamu623 rokamu623 requested review from emori-ctc and keita1523 and removed request for taro-yu and emori-ctc August 28, 2023 03:35
@rokamu623
fix: erase meaningless code
bd4890c 
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
@rokamu623
fix: resolve conflict
bda7bc7 
Signed-off-by: rokamu623 <r.okamura.061@ms.saitama-u.ac.jp>
keita1523
keita1523 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@keita1523 keita1523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nabetetsu
nabetetsu approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@nabetetsu nabetetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that worst_in_input gots worst value among the input candidates that make up the path as expected.

LGTM 👍

rt2-824 drawio

@rokamu623 rokamu623 merged commit e914881 into tier4:main Aug 31, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keita1523 keita1523 keita1523 approved these changes

@nabetetsu nabetetsu nabetetsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rokamu623 @keita1523 @nabetetsu