Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: docstring for method returning RecordsCppImpl and TracePointData #528

Merged
merged 14 commits into from
Sep 19, 2024
Merged

refactor: docstring for method returning RecordsCppImpl and TracePointData #528

merged 14 commits into from
Sep 19, 2024
+70 −10

Conversation

h-suzuki-isp
Copy link
Contributor

@h-suzuki-isp h-suzuki-isp commented Sep 6, 2024 •
edited
Loading

Description

Fix docstring for method returning RecordsCppImpl and TracePointData

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-suzuki-isp
refactor: docstring
ad59288 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
doc: change spell
5b124bd 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp h-suzuki-isp marked this pull request as ready for review September 9, 2024 02:27
@h-suzuki-isp
fix: docstring
f47d821 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix: docstring style
66ae80d 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix: docstirng style
ceca29f 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix: docstring compose_callback_records
f949308 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix add space before columns
22731dc 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix: docstring
04b78d4 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
h-suzuki-isp and others added 3 commits September 19, 2024 17:39
@h-suzuki-isp @ymski
Update src/caret_analyze/infra/lttng/lttng_info.py
3120377 
Co-authored-by: ymski <yamasaki@isp.co.jp>
@h-suzuki-isp @ymski
Update src/caret_analyze/infra/lttng/lttng_info.py
59906ab 
Co-authored-by: ymski <yamasaki@isp.co.jp>
@h-suzuki-isp
Fix: communication_records docstring
d1b9522 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
ymski
ymski approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-suzuki-isp h-suzuki-isp merged commit 3efcfba into tier4:main Sep 19, 2024
8 of 9 checks passed
@h-suzuki-isp h-suzuki-isp deleted the refactor_docstring branch September 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymski ymski ymski approved these changes

Assignees
No one assigned
Labels
deploy-docs tag:deploy-docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-suzuki-isp @ymski