Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary workaround for the issue where typeguard 2.2.2 is installed #529

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

h-suzuki-isp
Copy link
Contributor

@h-suzuki-isp h-suzuki-isp commented Sep 11, 2024

Description

On the current Docker image, python3-typeguard=2.2.2 is installed. Since this version causes inconsistencies, we are applying a temporary workaround to reinstall typeguard.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp h-suzuki-isp marked this pull request as ready for review September 11, 2024 10:05
@h-suzuki-isp h-suzuki-isp changed the title feat: install latest typeguard Fix: Temporary workaround for the issue where typeguard2.2.2 is installed Sep 11, 2024
@h-suzuki-isp h-suzuki-isp changed the title Fix: Temporary workaround for the issue where typeguard2.2.2 is installed fix: Temporary workaround for the issue where typeguard2.2.2 is installed Sep 11, 2024
@h-suzuki-isp h-suzuki-isp changed the title fix: Temporary workaround for the issue where typeguard2.2.2 is installed fix: Temporary workaround for the issue where typeguard 2.2.2 is installed Sep 11, 2024
@h-suzuki-isp h-suzuki-isp changed the title fix: Temporary workaround for the issue where typeguard 2.2.2 is installed fix: Temporary workaround for the issue where unsupported typeguard is installed Sep 11, 2024
@h-suzuki-isp h-suzuki-isp changed the title fix: Temporary workaround for the issue where unsupported typeguard is installed fix: temporary workaround for the issue where typeguard 2.2.2 is installed Sep 11, 2024
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-suzuki-isp h-suzuki-isp merged commit 9ede8ba into tier4:main Sep 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants