Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ros2numpy > 0.0.4 #126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ralwing
Copy link
Contributor

@ralwing ralwing commented Jul 8, 2024

Description

Supporting current version of ros2_numpy package, instead of old

This change allows also to work with both the driving log replayer and t4_perception_dataset

@ralwing ralwing changed the title Support ros2numpy feat: support ros2numpy > 0.0.4 Jul 8, 2024
@miursh
Copy link
Collaborator

miursh commented Jul 9, 2024

@ralwing
Thank you for your contribution!
Could you please update the poetry file to install the new ros2_numpy?

@ralwing
Copy link
Contributor Author

ralwing commented Jul 10, 2024

Could you please update the poetry file to install the new ros2_numpy?

Regrettably, the pip repository doesn't have an updated version of this package available. Therefore, I'm utilizing the Box-robotics repository for installation. With your consent, I'll include it in the build_depends.repos and consequently remove it from the Poetry requirements.

@miursh
Copy link
Collaborator

miursh commented Jul 25, 2024

@ralwing
Sorry for the delayed response.

Instead of adding it to build_depends, would it be possible to use this PR (after merged) or just use the PR original branch ?
By using above PR, we can use poetry add git+ssh://git@github.com:mbpeterson70/ros2_numpy.git#humble to add newer ros2_numpy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants