-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deepen_to_t4_segmentation): add deepen_to_t4(object_ann.json) converter for 2d segmentation #152
Draft
Shin-kyoto
wants to merge
22
commits into
main
Choose a base branch
from
feat/add-deepen-to-t4-segmentation-converter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nverter for 2d segmentation Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…tion file Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
for more information, see https://pre-commit.ci
…stic names Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…o segmentation directory Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…entation zip file to deepen annotation Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…EMENTATION Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Shin-kyoto
force-pushed
the
feat/add-deepen-to-t4-segmentation-converter
branch
from
October 9, 2024 09:37
e508712
to
784fa30
Compare
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…4dataset conversion Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…gons. PLEASE REVERT IT BEFORE MERGE!!! Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…ion json Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…polygons Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
… of camera in data and deepen is incosistent. THIS IS TENTATIVE IIMPLEMENTATION. PLEASE REVERT ME Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to review
How to test
test data
test command
Reference
Notes for reviewer
The following are the challenging parts of the implementation:
Since ObjectAnn always requires a 2D bounding box, a dummy value is being inserted for the 2D bbox.
The mask argument of
_convert_to_t4_format
is of typeList[Dict[int, str]]
, which is insufficient for storing masks per frame and instance.mask[sensor_id][frame_index]
.In this implementation, as a last resort, I replaced the process where
anno_two_d_box
is created with generating RLE instead.height
andwidth
, which forced me to choose between creating an instance of the nuImages class or using the size from the mask. I opted for the latter, but this approach involves generating a mask that encompasses the entire image, solely to obtain the size, which is not necessary for 2D segmentation and is an inelegant solution.This code works well if I use
polygons[0]
in line 306 of annotation_files_generator.py. But I do not know the reason 🤔