Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deepen_to_t4_segmentation): add deepen_to_t4(object_ann.json) converter for 2d segmentation #152

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

Shin-kyoto
Copy link
Contributor

@Shin-kyoto Shin-kyoto commented Sep 9, 2024

Description

  • Add deepen_to_t4 converter for 2d segmentation.
  • TODO: add tests

How to review

  • Please check Notes for reviewer, and give me your advice.

How to test

test data

  • To be filled

test command

Reference

Notes for reviewer

The following are the challenging parts of the implementation:

  • Since ObjectAnn always requires a 2D bounding box, a dummy value is being inserted for the 2D bbox.

    • For 2D detection, a dummy mask encompassing the entire image is also being used. This results in an unnatural aspect of the overall implementation.
  • The mask argument of _convert_to_t4_format is of type List[Dict[int, str]], which is insufficient for storing masks per frame and instance.

    • It is currently used for 2D detection as mask[sensor_id][frame_index].
    • As a result, the interface is not expandable for 2D segmentation.
  • In this implementation, as a last resort, I replaced the process where anno_two_d_box is created with generating RLE instead.

    • However, creating RLE requires height and width, which forced me to choose between creating an instance of the nuImages class or using the size from the mask. I opted for the latter, but this approach involves generating a mask that encompasses the entire image, solely to obtain the size, which is not necessary for 2D segmentation and is an inelegant solution.
  • This code works well if I use polygons[0] in line 306 of annotation_files_generator.py. But I do not know the reason 🤔

…nverter for 2d segmentation

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Shin-kyoto and others added 9 commits October 7, 2024 15:40
…tion file

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…stic names

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…o segmentation directory

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…entation zip file to deepen annotation

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…EMENTATION

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
@Shin-kyoto Shin-kyoto force-pushed the feat/add-deepen-to-t4-segmentation-converter branch from e508712 to 784fa30 Compare October 9, 2024 09:37
Shin-kyoto and others added 12 commits October 9, 2024 21:42
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…4dataset conversion

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…gons. PLEASE REVERT IT BEFORE MERGE!!!

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…ion json

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
…polygons

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
… of camera in data and deepen is incosistent. THIS IS TENTATIVE IIMPLEMENTATION. PLEASE REVERT ME

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant