-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telegram notification support #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philenst
added
AlertSender
enhancement
New feature or request
NotificationHandler
documentation
Improvements or additions to documentation
labels
Sep 9, 2023
tigattack
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this looks pretty good, thanks Phil.
Couple questions and suggestions, but I'm happy to merge once resolved.
Co-authored-by: tigattack <10629864+tigattack@users.noreply.github.com>
tigattack
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Phil ❤️
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AlertSender
documentation
Improvements or additions to documentation
enhancement
New feature or request
NotificationHandler
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for sending to Telegram:
Introduces 2 new configs:
Does require to duplicate some logs however not really avoidable without writing dedicated functions for it.
Also splits off Send-Payload to Send-JSONPayload (As it converts the body to JSON) and has a new Send-Payload function.
Ideally replaces PR #49