Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram notification support #63

Merged
merged 12 commits into from
Jan 18, 2024
Merged

Telegram notification support #63

merged 12 commits into from
Jan 18, 2024

Conversation

Philenst
Copy link
Collaborator

@Philenst Philenst commented Sep 8, 2023

Adds support for sending to Telegram:

image

Introduces 2 new configs:

  • bot_token, which should be a bot token
  • chat_id, which should be the chat ID of the user receiving the notifications.

Does require to duplicate some logs however not really avoidable without writing dedicated functions for it.

Also splits off Send-Payload to Send-JSONPayload (As it converts the body to JSON) and has a new Send-Payload function.

Ideally replaces PR #49

@Philenst Philenst self-assigned this Sep 8, 2023
@Philenst Philenst added AlertSender enhancement New feature or request NotificationHandler documentation Improvements or additions to documentation labels Sep 9, 2023
Copy link
Owner

@tigattack tigattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks pretty good, thanks Phil.

Couple questions and suggestions, but I'm happy to merge once resolved.

resources/NotificationHandler.psm1 Outdated Show resolved Hide resolved
resources/NotificationHandler.psm1 Outdated Show resolved Hide resolved
AlertSender.ps1 Show resolved Hide resolved
Philenst and others added 3 commits January 18, 2024 10:28
Copy link
Owner

@tigattack tigattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Phil ❤️

@tigattack tigattack merged commit 5488772 into tigattack:main Jan 18, 2024
5 checks passed
@Philenst Philenst mentioned this pull request Jan 18, 2024
@tigattack tigattack linked an issue Jan 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AlertSender documentation Improvements or additions to documentation enhancement New feature or request NotificationHandler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Telegram service support
2 participants