Recreate certificates that are only specified to be used as server certs #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelljerram
reviewed
Jul 25, 2023
tmjd
reviewed
Jul 25, 2023
rene-dekker
reviewed
Jul 25, 2023
tmjd
reviewed
Jul 26, 2023
caseydavenport
force-pushed
the
casey-recreate-invalid-certs
branch
from
9484977
to
6f9ccc0
Compare
caseydavenport
force-pushed
the
casey-recreate-invalid-certs
branch
from
b534d4d
to
d5019b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Old clusters from before Calico Enterprise v3.13 created certificates
that were only valid as server certs.
In v3.17, we have updated these connections to use mTLS, and so these
certs are also used as client certs.
This PR updates the operator to spot when certificates issued by the
tigera-operator-signer do not have the necessary ExtUsageKeyClientAuth
usage, and regenerates them if so.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.