Cert fix #2775
Merged
Cert fix #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmjd
force-pushed
the
cert-fix
branch
2 times, most recently
from
6524240
to
461d480
Compare
caseydavenport
approved these changes
Jul 31, 2023
- Only require key usage for certain secret certs - Compliance: order dependencies so certificates are updated before pods are updated.
rene-dekker
reviewed
Jul 31, 2023
| @@ -85,6 +87,14 @@ var ( | |||
| ComplianceReporterSourceEntityRule = networkpolicy.CreateSourceEntityRule(ComplianceNamespace, ComplianceReporterName) | |||
| ) | |||
|
|
|||
| // Register secret/certs that need Server and Client Key usage | |||
| func init() { | |||
| certkeyusage.SetCertKeyUsage(ComplianceServerCertSecret, []x509.ExtKeyUsage{x509.ExtKeyUsageClientAuth, x509.ExtKeyUsageServerAuth}) | |||
There was a problem hiding this comment.
When considering the init function, what made you decide to do it in the render file, rather than the controller?
There was a problem hiding this comment.
Mainly because that is where the secret name is defined.
There was a problem hiding this comment.
I can justify it as the render is where we define the state/configuration of components, so it makes sense that we define the state/configuration of the secrets. But I'm sure we could come up with rationale that it should be in the controller.
tmjd
added a commit
that referenced
this pull request
Jul 31, 2023
[pick #2775] Recreate certificates that are only specified to be used as server certs [r1.31]
tmjd
added a commit
that referenced
this pull request
Jul 31, 2023
[Pick #2775] Recreate certificates that are only specified to be used as server certs [r1.30]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.