Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pick #2775] Recreate certificates that are only specified to be used as server certs [r1.31] #2777

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented Jul 31, 2023

  • Only require key usage for certain secret certs
  • Compliance: order dependencies so certificates are updated before pods are updated.

Description

Pick #2775 to release-v1.31

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

- Only require key usage for certain secret certs
- Compliance: order dependencies so certificates are updated before pods
  are updated.
@tmjd tmjd requested a review from a team as a code owner July 31, 2023 18:19
@marvin-tigera marvin-tigera added this to the v1.31.0 milestone Jul 31, 2023
@tmjd tmjd changed the title [pick #2775] Recreate certificates that are only specified to be used as server certs [r1.31 [pick #2775] Recreate certificates that are only specified to be used as server certs [r1.31] Jul 31, 2023
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tmjd tmjd merged commit 69b5df1 into tigera:release-v1.31 Jul 31, 2023
@tmjd tmjd deleted the r131-pick2775 branch July 31, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants