Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suspend and wakeup commands #17

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Add suspend and wakeup commands #17

merged 1 commit into from
Sep 23, 2024

Conversation

Nerox9
Copy link
Contributor

@Nerox9 Nerox9 commented Sep 18, 2024

Description

Suspend and wake-up commands are added into admin server with systemctl targets.

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Run the command on guivm grpcurl -plaintext 192.168.101.10:9000 admin.AdminService.Suspend.
Observe the turned off display.
Interact with any key and observe the display turned on back.

Suspend and wake-up commands are added into admin server with systemctl targets

Signed-off-by: Berk Arslan <berk.arslan@unikie.com>
Copy link
Contributor

@slakkala slakkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

@vunnyso
Copy link

vunnyso commented Sep 18, 2024

Does this PR replicate same behavior of doing system suspend from ghaf-host ?
If yes, unfortunately our gui-vm cannot suspend because virtio fs doesn't support suspend as of now with 6.10.2 kernel. We can turn off display of gui-vm as mentioned here to have better battery life.

@Nerox9
Copy link
Contributor Author

Nerox9 commented Sep 20, 2024

Does this PR replicate same behavior of doing system suspend from ghaf-host ? If yes, unfortunately our gui-vm cannot suspend because virtio fs doesn't support suspend as of now with 6.10.2 kernel. We can turn off display of gui-vm as mentioned here to have better battery life.

Right, but we need to trigger it from GUI VM over GIVC too. Basically naming is just for the future implementation otherwise it uses the implementation you mentioned for now.

@Nerox9 Nerox9 marked this pull request as ready for review September 20, 2024 14:59
@Nerox9 Nerox9 merged commit c50f663 into tiiuae:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants