Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stop and paure/resume in client #22

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Implement stop and paure/resume in client #22

merged 2 commits into from
Oct 23, 2024

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Oct 21, 2024

Description

Implement stop and paure/resume in client

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Test routine to stop added to nixos/tests/*

@avnik
Fix managed endpoints resolving
2bac7b3 
Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>
@avnik
Implement stop/pause/resume in client code, add test
cf9df3c 
Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>
@mbssrc mbssrc merged commit cd2b991 into tiiuae:main Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbssrc mbssrc mbssrc left review comments

@dmitry-erin dmitry-erin Awaiting requested review from dmitry-erin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avnik @mbssrc