-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rclone-http into a module #108
Conversation
0118f84
to
79dbf25
Compare
79dbf25
to
d819156
Compare
d819156
to
0f0a6a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly related to the below comments, in testing this configuration, I see the caddy
service on binary-cache VM fails to start with the following error:
Apr 05 05:06:53 ghaf-binary-cache-henrirosten systemd[1]: Starting Caddy...
Apr 05 05:07:03 ghaf-binary-cache-henrirosten caddy[955]: {"level":"info","ts":1712293623.4792607,"msg":"using provided configuration","config_file":"/etc/caddy/caddy_config","config_adapter":"caddyfile"}
Apr 05 05:07:03 ghaf-binary-cache-henrirosten caddy[955]: Error: adapting config using caddyfile: server block without any key is global configuration, and if used, it must be first
Apr 05 05:07:03 ghaf-binary-cache-henrirosten systemd[1]: caddy.service: Main process exited, code=exited, status=1/FAILURE
Apr 05 05:07:03 ghaf-binary-cache-henrirosten systemd[1]: caddy.service: Failed with result 'exit-code'.
Apr 05 05:07:03 ghaf-binary-cache-henrirosten systemd[1]: Failed to start Caddy.
Did it work in your tests? I see this error when deploying to a new environment (previously unexisting environment).
It seems I removed one line too many when getting rid of the workaround. |
Signed-off-by: Joonas Rautiola <joonas.rautiola@unikie.com>
0f0a6a5
to
0d179b4
Compare
Replaced copypasted rclone-http services with a reusable module, with configurable options. The caddyfile workaround is also removed as the fix has been merged into nixpkgs and backported to our version.