hosts/*: remove lib.flatten usage #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
force-pushed
the
remove-flatten-in-imports
branch
2 times, most recently
from
24b2fc3
to
341770a
Compare
joinemm
requested changes
Apr 10, 2024
We can simply concatenate lists with the `++` operator, no need to call lib.flatten on a list of lists to archieve the same thing. Also, remove the surrounding with statement in case it's only used once or twice, and sort file imports before others. Signed-off-by: Florian Klink <flokli@flokli.de>
flokli
force-pushed
the
remove-flatten-in-imports
branch
from
341770a
to
24e43f4
Compare
joinemm
approved these changes
Apr 10, 2024
henrirosten
approved these changes
Apr 10, 2024
|
Change LGTM, but how we are going to test this? |
|
It's only syntactic changes, the resulting nix expressions and store paths are the same before and after. Edit: Ah no, they're not, due to the flake content hash itself also leaking into the expression. But a |
tervis-unikie
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can simply concatenate lists with the
++operator, no need to call lib.flatten on a list of lists to archieve the same thing.Also, remove the surrounding with statement in case it's only used once or twice, and sort file imports before others.