-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghaf infra new environments #276
base: main
Are you sure you want to change the base?
Conversation
a43f30f
to
340fe39
Compare
5b2fada
to
dff761d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quite large changes -hoping tested well!
61359e5
to
eb4eb5a
Compare
@karim20230 : thanks for the review. I also struggled as to how to split this in smaller, more digestible pieces. I couldn't figure out how to split the first two commits that are required to align with the new setup. Other commits in this PR are smaller, hopefully easier to understand. |
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
eb4eb5a
to
a0d1735
Compare
Rebased on latest main |
Support ghaf-infra deployments as outlined in https://ssrc.atlassian.net/wiki/spaces/SP/pages/1357250598/Ghaf-infra+Environments:
This change also introduces changes to critical resource storage:
In addition, the changes in this PR enable creating concurrent ghaf-infra instances of the same type. As an example, we could have two 'prod' deployments (with different names) running concurrently. Similarly, ghaf-infra developers can now have many 'priv' environments running concurrently.
Removes
terraform-playground.sh
: we should now useterraform-init.sh
and the instructions interraform/README.md
to achieve the same functionality.