Don't ban office ip address #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjuntunen
previously approved these changes
Oct 23, 2024
karim20230
previously approved these changes
Oct 23, 2024
|
I hate it when we have to hardcode internal details of our own network to what is supposed to be code reusable also in other installations. |
henrirosten
previously approved these changes
Oct 24, 2024
There are many places in the infra already where our internal ip addresses or specific hardware are referenced, but yes I can add a comment explaining what this address is. |
Signed-off-by: Joonas Rautiola <joonas.rautiola@unikie.com>
joinemm
dismissed stale reviews from henrirosten, karim20230, and vjuntunen
via
1657545
joinemm
force-pushed
the
pr-fail2ban-whitelist
branch
from
19630a7
to
1657545
Compare
henrirosten
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.