Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86 builder: Include ficolohosts module #43

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

mkaapu
Copy link
Contributor

@mkaapu mkaapu commented Dec 20, 2023

General ficolohosts module defining extra hosts were tested and introduced after x86 builder configuration.

  • Removing extra hosts configuration from hosts/ficolobuild/configuration.nix
  • Including ficolohosts module
  • This also fixes a bug caused by using double quotation marks instead of single ones to list extra hosts in configuration, which added extra spaces before the IP addresses in /etc/hosts which are not allowed.

Extra commit: Ganymede is taken down so removing that from extra hosts.

- Use already tested conf module instead of separate conf for x86

Signed-off-by: Marko Kaapu <marko.kaapu@unikie.com>
Signed-off-by: Marko Kaapu <marko.kaapu@unikie.com>
@mkaapu mkaapu merged commit d56a6ca into tiiuae:main Dec 21, 2023
1 check passed
@mkaapu mkaapu deleted the pr-fix-extrahosts branch December 21, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants