Add milval as developer for remote builder #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joonas Rautiola <joonas.rautiola@unikie.com>
karim20230
approved these changes
Feb 2, 2024
mkaapu
approved these changes
Feb 2, 2024
cazfi
requested changes
Feb 2, 2024
| { | ||
| name = "milval"; | ||
| keys = [ | ||
| "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC27Bw23c+I+h1Ppwf8++glx5yzKdgZ/tFFFcORtl7vlH5vbAr5umRj7DOijeyFMSUc/KuH7F5wMHwzTSkXYjhQINc1plzD1RXorC3mHBIrBqtAUTRgKU9t70FF1sNVyUy97Lu5hrnVEtQnqaBLm5EJdIyLxGfu1kzjvcvOA05KnwXqcehlsEASU8HnEs6tBUITqvkegePqIXU+z7KMG0pCpfOj76ImZq82Ih34o+D7cz8LiGdT1BiSBUl6CO/Q55oRwo9Eew/MCkj/jr9XKzX1biv3B1yqzIFTYcUsF/KqjX57w19KX+5crgvyJ5uN8GdKzw/Y8CtHrQqJU6UPLOnqqIixHPomoVPUNbpPW9aWTqhwZ8PG1KBuN/3XeJuPvW0EVYiQrnXFD2dnGz86QCZUSyIXicEoGjxUviFICPc8iFljQqNvUpehMtnMAgy1Wfl5F9o9NgFWOvvmFoxU9vVUVsS4aOLb3ke3mEg65m8YOL2vho3q+Ex5lnqynvHSsY0= root@nixos" |
There was a problem hiding this comment.
I wouldn't accept usage of rsa keys for this access. Require ed25519.
There was a problem hiding this comment.
I agree with @cazfi. ED25519 keys are more secure and performant than RSA keys. and public keys are shorter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.