Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jenkins service startup #76

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

henrirosten
Copy link
Collaborator

@henrirosten henrirosten commented Feb 14, 2024

Fix Jenkins service startup:

  • Delay jenkins service startup by making it run after multi-user.target.
  • Add a comment pointing to future work for improving the cloud-init usage together with azure agent.
  • Make both cloud-config.service and jenkins.service restart on failure.

@henrirosten henrirosten marked this pull request as ready for review February 14, 2024 16:37
@henrirosten henrirosten requested a review from a team February 14, 2024 16:38
karim20230
karim20230 previously approved these changes Feb 14, 2024
joinemm
joinemm previously approved these changes Feb 14, 2024
Copy link

@mnokka mnokka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logical order reorder

Delay jenkins service startup by making it run after
`multi-user.target`.

Add a comment pointing to future work for improving the cloud-init usage
together with azure agent.

Make both cloud-config.service and jenkins.service restart on failure.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten henrirosten dismissed stale reviews from joinemm and karim20230 via 53c2714 February 15, 2024 11:16
@henrirosten henrirosten requested review from joinemm, karim20230, mnokka and a team and removed request for mnokka February 15, 2024 11:26
@henrirosten
Copy link
Collaborator Author

Had to push a new version due to issues I noticed while testing the earlier change.

@henrirosten henrirosten merged commit ee91375 into main Feb 15, 2024
1 check passed
@henrirosten henrirosten deleted the wip-ng-fix-jenkins-startup branch February 16, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants