Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nginx import #79

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix Nginx import #79

merged 1 commit into from
Feb 21, 2024

Conversation

karim20230
Copy link
Member

@karim20230 karim20230 commented Feb 20, 2024 •
edited
Loading

Fix Nginx import

@karim20230 karim20230 changed the title fix inginx import fix nginx import Feb 20, 2024
tervis-unikie
tervis-unikie suggested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@tervis-unikie tervis-unikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect subject capitalization.
Take githooks into use and check action outputs when making a PR.

@karim20230 karim20230 changed the title fix nginx import Fix Nginx import Feb 21, 2024
@karim20230
Fix Nginx import
5ee349e 
Signed-off-by: karim mdmirajul <karim.mdmirajul@unikie.com>
@karim20230 karim20230 merged commit aa36706 into tiiuae:main Feb 21, 2024
2 checks passed
@karim20230 karim20230 deleted the fix-inginx branch February 21, 2024 15:10
fayadf pushed a commit to fayadf/ghaf-infra that referenced this pull request Oct 2, 2024
@karim20230
Fix Nginx import (tiiuae#79)
cbdd6ff 
Signed-off-by: karim mdmirajul <karim.mdmirajul@unikie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joinemm joinemm joinemm approved these changes

@tervis-unikie tervis-unikie tervis-unikie approved these changes

@cazfi cazfi Awaiting requested review from cazfi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karim20230 @joinemm @tervis-unikie