Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tasks.py usage #8

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Simplify tasks.py usage #8

merged 1 commit into from
Nov 6, 2023

Conversation

henrirosten
Copy link
Collaborator

  • Introduce 'alias' names for combinations of hostname (IP) and target nixosConfigurations.
  • Add task alias-list to list all alias names currently configured.
  • Change the task.py so that all tasks take the 'alias' name as an argument, instead of separate hostname and configuration name. This makes it less likely to accidentally apply a configuration to a wrong host.
  • This also makes it possible to apply tasks to all alias names. As an example, deploy without arguments could deploy all specified alias configurations at once. Such changes to tasks will be implemented later in a separate PR.

- Introduce 'alias' names for combinations of hostname (IP) and
  target nixosConfigurations.
- Add task `alias-list` to list all alias names currently configured.
- Change the task.py so that all tasks take the 'alias' name as an
  argument, instead of separate hostname and configuration name.
  This makes it less likely to accidentally apply a configuration to a
  wrong host.
- This also makes it possible to apply tasks to all alias names. As an
  example, `deploy` without arguments could deploy all specified alias
  configurations at once. Such changes to tasks will be implemented
  later in a separate PR.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten henrirosten requested a review from a team November 3, 2023 13:57
@henrirosten henrirosten marked this pull request as ready for review November 3, 2023 14:00
@alextserepov
Copy link
Contributor

alextserepov commented Nov 6, 2023

Just a thought for now, but shall we use something with PKCS#11 interface instead of SOPS already at this point?

@henrirosten
Copy link
Collaborator Author

Just a thought for now, but shall we use something with PKCS#11 interface instead of SOPS already at this point?

@alextserepov : I would propose we have this discussion separately, it's not really related to this PR.

@henrirosten henrirosten merged commit 592c16c into main Nov 6, 2023
1 check passed
henrirosten added a commit that referenced this pull request Nov 6, 2023
- Pin nixos-anywhere to prevent possible issues caused by upstream PR:
  nix-community/nixos-anywhere#243.
  Read more from the below nixpkgs issue:
  NixOS/nixpkgs#265014.
- Fix the task.py usage instructions in README.md after
  #8.
- Make `nix flake check` pre-push check less verbose.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten henrirosten deleted the tasks-simplify branch November 6, 2023 10:59
henrirosten added a commit that referenced this pull request Nov 6, 2023
- Pin nixos-anywhere to prevent possible issues caused by upstream PR:
  nix-community/nixos-anywhere#243.
  Read more from the below nixpkgs issue:
  NixOS/nixpkgs#265014.
- Fix the task.py usage instructions in README.md after
  #8.
- Make `nix flake check` pre-push check less verbose.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
fayadf pushed a commit to fayadf/ghaf-infra that referenced this pull request Oct 2, 2024
- Pin nixos-anywhere to prevent possible issues caused by upstream PR:
  nix-community/nixos-anywhere#243.
  Read more from the below nixpkgs issue:
  NixOS/nixpkgs#265014.
- Fix the task.py usage instructions in README.md after
  tiiuae#8.
- Make `nix flake check` pre-push check less verbose.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants