Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make osdisk size configurable #84

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Make osdisk size configurable #84

merged 1 commit into from
Feb 27, 2024

Conversation

tervis-unikie
Copy link
Contributor

Default osdisk sizes:

  • jenkins-controller: 150 GB
  • builder: 150 GB
  • binary-cache: 50 GB

Default osdisk sizes:
- jenkins-controller: 150 GB
- builder: 150 GB
- binary-cache: 50 GB

Signed-off-by: Tero Tervala <tero.tervala@unikie.com>
@tervis-unikie tervis-unikie requested a review from a team February 27, 2024 09:57
Copy link
Collaborator

@henrirosten henrirosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tervis-unikie : thanks for this change.

I think we should make the disk size configurable per environment, something similar to:

opts = {
priv = {
vm_size_binarycache = "Standard_D1_v2"
vm_size_builder = "Standard_D2_v3"
vm_size_controller = "Standard_D2_v3"
num_builders = 1
}
dev = {
vm_size_binarycache = "Standard_D1_v2"
vm_size_builder = "Standard_D4_v3"
vm_size_controller = "Standard_D4_v3"
num_builders = 1
}
prod = {
vm_size_binarycache = "Standard_D2_v3"
vm_size_builder = "Standard_D8_v3"
vm_size_controller = "Standard_D8_v3"
num_builders = 2
}
}

and a usage example, for instance in:
virtual_machine_size = local.opts[local.conf].vm_size_controller

If you prefer having this merged first, and then later follow-up with another PR to take care of making it part of environment-specific configuration options, that's also fine.

@tervis-unikie
Copy link
Contributor Author

That is a good idea, but I'll rather merge this and then make another PR.

@tervis-unikie tervis-unikie merged commit a3d470c into main Feb 27, 2024
2 checks passed
@tervis-unikie tervis-unikie deleted the PR-osdisksize branch February 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants