-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardware definition refactoring #541
Conversation
General approach taken here, looks good to me. |
This is now in conflict, please rebase |
- moved hardware from common to a flake-module - re-factored 'generation' as parameter to hardware definition - quick fixed network device required in desktop stack (hw definition not available in vm namespaces) - fix references to modules/common/hardware Signed-off-by: Manuel Bluhm <manuel@ssrc.tii.ae>
…t module. Signed-off-by: Manuel Bluhm <manuel@ssrc.tii.ae>
- module with qemu rules, required packages and services, and polkit/pam configs; conditionally applied to guivmExtraModules - allows ghaf user to enroll and verify fingerprints - works with swaylock, sudo, systemctl (note: swaylock needs to be enabled) - swaylock works with password w/o fingerprint, when fp is enrolled it allows either password or fp. To use fp auth, press Enter and then do fp auth Further work required: - persistent fingerprint data storage required - proper integration with login manager (when ready) - potential enrollment application - swaylock bugs have been observed (some even w/o fingerprint) Signed-off-by: Manuel Bluhm <manuel@ssrc.tii.ae>
Signed-off-by: Manuel Bluhm <manuel@ssrc.tii.ae>
ci-test-automation passed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated test instructions look good enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test sets also run nicely 👍
Description of changes
This PR introduces
generation
parameter, which is now an optionguivm
Checklist for things done
x86_64
aarch64
riscv64
nix flake check --accept-flake-config
and it passesTesting
Tested by author:
.#lenovo-x1-carbon-gen11-debug
.#vm-debug
.#generic-x86_64-debug
(on x1)Test instructions:
fprintd-enroll
to enroll fingerprint. Run asudo
command andsystemctl restart systemd-timesyncd.service
, authenticate with fingerprint. In-depth testing not required at this point, as features are missing (see commit message). Expected outcome: fingerprint enrollment works, sudo and systemctl (system) commands can be authenticated with fingerprintconfig.ghaf.graphics.labwc.lock.enable
and build, enroll fingerprint, then runswaylock
(e.g., run in terminal), press Enter and use fingerprint reader to authenticate. Expected outcome: fingerprint authentication unlocks swaylock