Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waybar: lock the wifi-signal-strength script #549

Merged
merged 1 commit into from
Apr 9, 2024
Merged

waybar: lock the wifi-signal-strength script #549

merged 1 commit into from
Apr 9, 2024

Conversation

Nerox9
Copy link
Contributor

@Nerox9 Nerox9 commented Apr 8, 2024 •
edited
Loading

Description of changes

Multiple call from multiple instance of waybar causes race condition. flock and trap are used to eliminate.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@Nerox9 Nerox9 temporarily deployed to internal-build-workflow April 8, 2024 19:59 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Apr 9, 2024
brianmcgillion
brianmcgillion reviewed Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@brianmcgillion brianmcgillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just the one question on the trap

packages/wifi-signal-strength/default.nix Outdated Show resolved Hide resolved
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow April 9, 2024 11:13 — with GitHub Actions Inactive
@Nerox9
waybar: lock the wifi-signal-strength script
dea2265 
Multiple call from multiple instance of waybar causes race condition. flock is used to eliminate.

Signed-off-by: Berk Arslan <berk.arslan@unikie.com>
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow April 9, 2024 19:04 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion merged commit ae77a61 into tiiuae:main Apr 9, 2024
13 checks passed
@milva-unikie
Copy link

Tested with X1 that this does fix the problem and everything else is working normally.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@baz2142 baz2142 Awaiting requested review from baz2142

@leivos-unikie leivos-unikie Awaiting requested review from leivos-unikie

@emrahbillur emrahbillur Awaiting requested review from emrahbillur

@milva-unikie milva-unikie Awaiting requested review from milva-unikie

@vadika vadika Awaiting requested review from vadika

Assignees
No one assigned
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nerox9 @milva-unikie @brianmcgillion