Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor USB network card patch a bit #553

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Refactor USB network card patch a bit #553

merged 1 commit into from
Apr 10, 2024

Conversation

mikatammi
Copy link
Contributor

@mikatammi mikatammi commented Apr 10, 2024 •
edited
Loading

Description of changes

  • Rename the module to ax88179_178a, which is the kernel module name.
  • Enable manually based on option instead of condition based on config.boot.kernelPackages.kernel.version, which started to cause infinite recursion when evaluating against nixos-unstable.
  • Enable manually only for platforms knwon having affected 6.1.x kernel.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Just regular builds. This still does not fix builds against nixos-unstable which have other issues, but at least makes them evaluate. Did not cause rebuiilds so I'm guessing this is fine.

Refactor USB network card patch a bit
8800210 
* Rename the module to ax88179_178a, which is the kernel module name.
* Enable manually based on option instead of condition based on
  config.boot.kernelPackages.kernel.version, which started to cause
  infinite recursion when evaluating against nixos-unstable.
* Enable manually only for platforms knwon having affected 6.1.x kernel.

Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
@mikatammi mikatammi temporarily deployed to internal-build-workflow April 10, 2024 14:38 — with GitHub Actions Inactive
@mikatammi mikatammi marked this pull request as ready for review April 10, 2024 14:44
@mikatammi mikatammi added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on NUC This PR has been tested on Intel NUC Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board labels Apr 10, 2024
@brianmcgillion brianmcgillion merged commit 929712f into tiiuae:main Apr 10, 2024
13 checks passed
@mikatammi mikatammi deleted the usb-network-kernel-patch branch April 10, 2024 14:55
@mikatammi
Copy link
Contributor Author

This should fix #551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

Assignees
No one assigned
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on NUC This PR has been tested on Intel NUC Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikatammi @brianmcgillion