Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable demoApplications for generic-x86_64 #554

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Re-enable demoApplications for generic-x86_64 #554

merged 1 commit into from
Apr 10, 2024

Conversation

mikatammi
Copy link
Contributor

Description of changes

Disabling demoApplications broke our automated test cases, which check the apps can actually start

I want to re-enable demoApps because I think we should also support the host-only usecase (without VMs), and the tests are already (lightly) checking that.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Intel NUC x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Tested on NUC, checked that application tests started to pass again.

Re-enable demoApplications for generic-x86_64
d3b0a3c 
Disabling demoApplications broke our automated test cases, which check
the apps can actually start

Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
@mikatammi mikatammi temporarily deployed to internal-build-workflow April 10, 2024 15:27 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion merged commit d616449 into tiiuae:main Apr 10, 2024
13 checks passed
@mikatammi mikatammi deleted the reenable_nuc_demoapps branch April 10, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@nesteroff nesteroff Awaiting requested review from nesteroff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikatammi @brianmcgillion