Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: guard all templates against unexpected arguments #559

Merged
merged 1 commit into from
Apr 11, 2024
Merged

templates: guard all templates against unexpected arguments #559

merged 1 commit into from
Apr 11, 2024

Conversation

Mic92
Copy link
Collaborator

@Mic92 Mic92 commented Apr 11, 2024 •
edited
Loading

User might include inputs for overriding input dependencies without actually using those.

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@Mic92 Mic92 temporarily deployed to internal-build-workflow April 11, 2024 14:23 — with GitHub Actions Inactive
@Mic92 Mic92 had a problem deploying to external-build-workflow April 11, 2024 14:23 — with GitHub Actions Failure
@Mic92
templates: guard all templates against unexpected arguments
8b9f83c 
User might include inputs for overriding input dependencies without
actually using those.

Signed-off-by: Jörg Thalheim <joerg@thalheim.io>
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 11, 2024 14:24 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to external-build-workflow April 11, 2024 14:24 — with GitHub Actions Inactive
@Mic92 Mic92 mentioned this pull request Apr 11, 2024
Merged
14 tasks
@brianmcgillion brianmcgillion merged commit f5dcb09 into tiiuae:main Apr 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @brianmcgillion