Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add regression test for all templates #560

Merged
merged 1 commit into from
Apr 15, 2024
Merged

add regression test for all templates #560

merged 1 commit into from
Apr 15, 2024

Conversation

Mic92
Copy link
Collaborator

@Mic92 Mic92 commented Apr 11, 2024 •
edited
Loading

Description of changes

We broke the templates in the past and this should help for the future.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@Mic92 Mic92 temporarily deployed to internal-build-workflow April 11, 2024 14:55 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 11, 2024 14:55 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 11, 2024 14:56 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 11, 2024 14:56 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 11, 2024 14:58 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 11, 2024 14:59 — with GitHub Actions Inactive
@remimimimimi
Copy link
Contributor

#445

@Mic92 Mic92 temporarily deployed to internal-build-workflow April 12, 2024 18:06 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 12, 2024 18:07 — with GitHub Actions Inactive
@Mic92
add regression test for all templates
0658031 
Signed-off-by: Jörg Thalheim <joerg@thalheim.io>
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 12, 2024 18:12 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 12, 2024 18:13 — with GitHub Actions Inactive
@Mic92
Copy link
Collaborator Author

Mic92 commented Apr 12, 2024

I made now the tmpdir handling more sane.

@brianmcgillion brianmcgillion merged commit 4609c2d into main Apr 15, 2024
13 checks passed
@brianmcgillion brianmcgillion deleted the template-check branch April 15, 2024 20:28
@Mic92 Mic92 mentioned this pull request Apr 16, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@henrirosten henrirosten Awaiting requested review from henrirosten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mic92 @remimimimimi @brianmcgillion