Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust GitHub build verbosity #579

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Adjust GitHub build verbosity #579

merged 3 commits into from
Apr 29, 2024

Conversation

henrirosten
Copy link
Collaborator

@henrirosten henrirosten commented Apr 29, 2024 •
edited
Loading

Description of changes

Don't print full build logs on the github build workflow.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@henrirosten
GhA: Don't print full build logs
6e4c880 
`tmpfs` filesystem on github-hosted runner can run out of disk space
due to excessive logging. Drop the `-L` from the nix build to not
print the full build logs.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten
GhA: Increase build log-lines
1ceaa13 
Increase the number of lines of the tail of the log to show if a build
fails.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten
GhA: Make cachix watch-exec verbose
64d4ce4 
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten henrirosten temporarily deployed to internal-build-workflow April 29, 2024 05:30 — with GitHub Actions Inactive
@henrirosten henrirosten mentioned this pull request Apr 29, 2024
Closed
13 tasks
@henrirosten henrirosten marked this pull request as ready for review April 29, 2024 05:32
brianmcgillion
brianmcgillion approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@brianmcgillion brianmcgillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets see if this works

@brianmcgillion brianmcgillion merged commit be01b6d into main Apr 29, 2024
14 of 15 checks passed
@brianmcgillion brianmcgillion deleted the adjust-github-build-verbosity branch April 29, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrirosten @brianmcgillion