Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: proofread PR 422 #670

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Docs: proofread PR 422 #670

merged 1 commit into from
Jun 19, 2024

Conversation

jenninikko
Copy link
Collaborator

@jenninikko jenninikko commented Jun 18, 2024 •
edited
Loading

#422

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@jenninikko jenninikko temporarily deployed to internal-build-workflow June 18, 2024 13:50 — with GitHub Actions Inactive
@jenninikko jenninikko requested a review from riskuuse June 18, 2024 13:50
riskuuse
riskuuse reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@riskuuse riskuuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One correction to target reference device.
Otherwise looks good.

@jenninikko
Docs: proofread PR 422
dfb1499 
Signed-off-by: Jenni Nikolaenko <evgeniia.nikolaenko@unikie.com>
@jenninikko jenninikko temporarily deployed to internal-build-workflow June 19, 2024 12:40 — with GitHub Actions Inactive
@jenninikko jenninikko merged commit d6b6025 into tiiuae:main Jun 19, 2024
13 of 14 checks passed
@jenninikko jenninikko deleted the docs-proofr-422 branch June 19, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riskuuse riskuuse riskuuse left review comments

@brianmcgillion brianmcgillion brianmcgillion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenninikko @brianmcgillion @riskuuse