Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display management in gui vm #859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Display management in gui vm #859

wants to merge 1 commit into from
+82 −9

Conversation

gangaram-tii
Copy link
Contributor

Description of changes

  • Turn off the display when system is suspended (Lid closed) and turn on when it resumes(Lid Open).
  • Host notifies admin vm for the events and admin vm starts and stops display-resume and display suspend services based on event on gui vm.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to: Lenovo X1 x86_64
  • Is this a new feature
    • List the test steps to verify:
    • Close laptop lid and wait for 3-4 seconds and open the lid and check if display is suspended and restored.
    • Also check gui-vm and host-vm journalctl log for error. There should not be any error regarding display suspend and resume.
  • If it is an improvement how does it impact existing functionality?

@gangaram-tii gangaram-tii temporarily deployed to internal-build-workflow October 21, 2024 13:29 — with GitHub Actions Inactive
@gangaram-tii gangaram-tii force-pushed the pr__display_management_in_guivm branch from 24436c2 to cdbed41 Compare October 22, 2024 06:58
@gangaram-tii gangaram-tii temporarily deployed to internal-build-workflow October 22, 2024 06:58 — with GitHub Actions Inactive
@gangaram-tii gangaram-tii force-pushed the pr__display_management_in_guivm branch from cdbed41 to 93f1678 Compare October 22, 2024 10:00
@gangaram-tii gangaram-tii temporarily deployed to internal-build-workflow October 22, 2024 10:00 — with GitHub Actions Inactive
@gangaram-tii gangaram-tii force-pushed the pr__display_management_in_guivm branch from 93f1678 to f33efd9 Compare October 22, 2024 11:21
@gangaram-tii gangaram-tii temporarily deployed to internal-build-workflow October 22, 2024 11:21 — with GitHub Actions Inactive
mbssrc
mbssrc reviewed Oct 23, 2024
View reviewed changes
modules/givc/adminvm.nix Outdated
@@ -23,6 +23,8 @@ in
"givc-net-vm.service"
"givc-gui-vm.service"
"givc-audio-vm.service"
"display-suspend.service"
"display-resume.service"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't necessary to include here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in latest push.

mbssrc
mbssrc reviewed Oct 23, 2024
View reviewed changes
modules/givc/host.nix Outdated Show resolved Hide resolved
mbssrc
mbssrc reviewed Oct 23, 2024
View reviewed changes
modules/givc/host.nix Outdated Show resolved Hide resolved
@mbssrc
Copy link
Collaborator

mbssrc commented Oct 23, 2024

This bumps GIVC, so we need general checking of GIVC functionality as well. This also impacts #710 as the bump is newer.

@gangaram-tii
display management in gui vm
b4b747b 
- Turn off the display when system is suspended and turn on when it
  resumes.

Signed-off-by: Ganga Ram <Ganga.Ram@tii.ae>
@gangaram-tii gangaram-tii force-pushed the pr__display_management_in_guivm branch from f33efd9 to b4b747b Compare October 24, 2024 07:32
@gangaram-tii gangaram-tii temporarily deployed to internal-build-workflow October 24, 2024 07:32 — with GitHub Actions Inactive
@mbssrc mbssrc added the Needs Testing CI Team to pre-verify label Oct 25, 2024
@johannarautanen
Copy link

Tested with lenovo X1. flash-script used. Commit: b4b747b

Working:

  • Occasionally when you close laptop lid and wait for 3-4 seconds display is suspended and you open the lid it is resumed. you can opened a web page before closing the lid.
  • all other ghaf apps can be launched
  • ci-test automation cases ok

Issues:

  • most of the time is took about 20 seconds before display is suspended, when you open the lid it is resumed. You have save test editor file before closing the lid.
  • There was error in gui-vm and ghaf-host:
    guivm.txt
    ghafhost.txt

Screenshot from 2024-10-25 14-11-47
Screenshot from 2024-10-25 14-12-22

@johannarautanen johannarautanen added bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed Needs Testing CI Team to pre-verify labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbssrc mbssrc mbssrc approved these changes

@brianmcgillion brianmcgillion Awaiting requested review from brianmcgillion

Assignees
No one assigned
Labels
bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gangaram-tii @mbssrc @johannarautanen