-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: confirm edit goal by pressing enter #1581
Merged
Tushar-4781
merged 6 commits into
tijlleenders:main
from
vinaybadgujar102:#1077_confirm-new-goal-with-enter
Oct 30, 2023
Merged
feat: confirm edit goal by pressing enter #1581
Tushar-4781
merged 6 commits into
tijlleenders:main
from
vinaybadgujar102:#1077_confirm-new-goal-with-enter
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@vinaybadgujar102 Did you test on mobile? I get "Next" on my keyboard and it does what it says : move the cursor to duration field. For budget the behavior is OK. |
LGTM @Tushar-4781 Can you review the code ? |
tijlleenders
requested review from
Tushar-4781
and removed request for
tijlleenders
October 30, 2023 11:01
Tushar-4781
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1077