Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: confirm edit goal by pressing enter #1581

Conversation

vinaybadgujar102
Copy link
Collaborator

resolves #1077

@vercel
Copy link

vercel bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zinzen ✅ Ready (Inspect) Visit Preview Oct 30, 2023 9:22am

@tijlleenders
Copy link
Owner

tijlleenders commented Oct 30, 2023

@vinaybadgujar102 Did you test on mobile? I get "Next" on my keyboard and it does what it says : move the cursor to duration field.

For budget the behavior is OK.

@tijlleenders
Copy link
Owner

LGTM @Tushar-4781 Can you review the code ?

@tijlleenders tijlleenders requested review from Tushar-4781 and removed request for tijlleenders October 30, 2023 11:01
@Tushar-4781 Tushar-4781 merged commit 0ce71cf into tijlleenders:main Oct 30, 2023
5 checks passed
@vinaybadgujar102 vinaybadgujar102 deleted the #1077_confirm-new-goal-with-enter branch November 5, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm new edit goal with enter
3 participants