Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show error message in a modal when scheduler breaks #1922

Merged
merged 7 commits into from
May 26, 2024

Conversation

vinaybadgujar102
Copy link
Collaborator

@vinaybadgujar102 vinaybadgujar102 commented May 23, 2024

resolves #1917

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zinzen ✅ Ready (Inspect) Visit Preview May 26, 2024 5:08am

@vinaybadgujar102 vinaybadgujar102 marked this pull request as ready for review May 23, 2024 06:00
@tijlleenders
Copy link
Owner

@vinaybadgujar102 Any idea how to break the scheduler, so I can test this?

@vinaybadgujar102
Copy link
Collaborator Author

@tijlleenders I can push a commit temporarily which breaks the scheduler.

tijlleenders
tijlleenders previously approved these changes May 23, 2024
Copy link
Owner

@tijlleenders tijlleenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@tijlleenders
Copy link
Owner

@vinaybadgujar102 Can you remove the commit so we can merge this?

@tijlleenders tijlleenders merged commit f34b392 into main May 26, 2024
6 checks passed
@tijlleenders tijlleenders deleted the vin/-/scheduler-error branch May 26, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch scheduler error
2 participants