Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update timeBudget field in goalItem to be budget object or undefined #1923

Merged
merged 4 commits into from
May 26, 2024

Conversation

vinaybadgujar102
Copy link
Collaborator

resolves #1760

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zinzen ✅ Ready (Inspect) Visit Preview May 23, 2024 9:15am

@tijlleenders tijlleenders requested review from Tushar-4781 and removed request for tijlleenders May 23, 2024 06:09
@tijlleenders
Copy link
Owner

@vinaybadgujar102 I've asked @Tushar-4781 to review this.

src/models/GoalItem.ts Outdated Show resolved Hide resolved
src/helpers/GoalProcessor.ts Outdated Show resolved Hide resolved
@Tushar-4781 Tushar-4781 merged commit e149b37 into main May 26, 2024
6 checks passed
@tijlleenders tijlleenders deleted the vin/1760/budget_undefined branch July 21, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Possibly Null Values in timeBudget Property of GoalItem Interface
3 participants