fix: ensure confirmation state persists across sessions #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vinaybadgujar102
changed the title
vinaybadgujar102
changed the title
|
@vinaybadgujar102 The playwrigt test failing is the 'flaky' test again? |
|
Yeah the collaboration one |
bump |
Tushar-4781
previously approved these changes
Jul 18, 2024
vinaybadgujar102
dismissed stale reviews from Tushar-4781 and tijlleenders
via
3338bab
|
@Tushar-4781 fixed merge conflict. |
|
@Tushar-4781 bump |
Tushar-4781
previously approved these changes
Jul 21, 2024
|
@vinaybadgujar102 Can you resolve the merge conflicts? |
Done |
tijlleenders
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1925
The bug occurred due to mistyping the localStorage key name "confirmationState" as "confirmationService". To prevent similar issues in the future, I created an enum that maps localStorage keys to ensure type safety.