allow deleting contacts (WIP) #2086
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import GoalAvatar from "../GoalAvatar"; | ||
| import GoalTitle from "./components/GoalTitle"; | ||
| import GoalDropdown from "./components/GoalDropdown"; | ||
| import { GoalContainer } from "../ZItemContainer"; | ||
| import GoalIcon from "./components/GoalIcon"; | ||
| import NotificationSymbol from "@src/common/NotificationSymbol"; |
There was a problem hiding this comment.
🚫 [eslint] <import/order> reported by reviewdog 🐶@src/common/NotificationSymbol import should occur before import of ../GoalAvatar
| import GoalAvatar from "../GoalAvatar"; | |
| import GoalTitle from "./components/GoalTitle"; | |
| import GoalDropdown from "./components/GoalDropdown"; | |
| import { GoalContainer } from "../ZItemContainer"; | |
| import GoalIcon from "./components/GoalIcon"; | |
| import NotificationSymbol from "@src/common/NotificationSymbol"; | |
| import NotificationSymbol from "@src/common/NotificationSymbol"; | |
| import GoalAvatar from "../GoalAvatar"; | |
| import GoalTitle from "./components/GoalTitle"; | |
| import { GoalContainer } from "../ZItemContainer"; | |
| import GoalIcon from "./components/GoalIcon"; |
| import GoalAvatar from "../GoalAvatar"; | ||
| import GoalTitle from "./components/GoalTitle"; | ||
| import GoalDropdown from "./components/GoalDropdown"; | ||
| import { GoalContainer } from "../ZItemContainer"; | ||
| import GoalIcon from "./components/GoalIcon"; | ||
| import NotificationSymbol from "@src/common/NotificationSymbol"; | ||
| import CopyIcon from "@src/assets/CopyIcon"; |
There was a problem hiding this comment.
🚫 [eslint] <import/order> reported by reviewdog 🐶@src/assets/CopyIcon import should occur before import of ../GoalAvatar
| import GoalAvatar from "../GoalAvatar"; | |
| import GoalTitle from "./components/GoalTitle"; | |
| import GoalDropdown from "./components/GoalDropdown"; | |
| import { GoalContainer } from "../ZItemContainer"; | |
| import GoalIcon from "./components/GoalIcon"; | |
| import NotificationSymbol from "@src/common/NotificationSymbol"; | |
| import CopyIcon from "@src/assets/CopyIcon"; | |
| import CopyIcon from "@src/assets/CopyIcon"; | |
| import GoalAvatar from "../GoalAvatar"; | |
| import GoalTitle from "./components/GoalTitle"; | |
| import { GoalContainer } from "../ZItemContainer"; | |
| import GoalIcon from "./components/GoalIcon"; | |
| import NotificationSymbol from "@src/common/NotificationSymbol"; |
| import GoalAvatar from "../GoalAvatar"; | ||
| import GoalTitle from "./components/GoalTitle"; | ||
| import GoalDropdown from "./components/GoalDropdown"; | ||
| import { GoalContainer } from "../ZItemContainer"; | ||
| import GoalIcon from "./components/GoalIcon"; | ||
| import NotificationSymbol from "@src/common/NotificationSymbol"; | ||
| import CopyIcon from "@src/assets/CopyIcon"; | ||
| import TriangleIcon from "@src/assets/TriangleIcon"; |
There was a problem hiding this comment.
🚫 [eslint] <import/order> reported by reviewdog 🐶@src/assets/TriangleIcon import should occur before import of ../GoalAvatar
| import GoalAvatar from "../GoalAvatar"; | |
| import GoalTitle from "./components/GoalTitle"; | |
| import GoalDropdown from "./components/GoalDropdown"; | |
| import { GoalContainer } from "../ZItemContainer"; | |
| import GoalIcon from "./components/GoalIcon"; | |
| import NotificationSymbol from "@src/common/NotificationSymbol"; | |
| import CopyIcon from "@src/assets/CopyIcon"; | |
| import TriangleIcon from "@src/assets/TriangleIcon"; | |
| import TriangleIcon from "@src/assets/TriangleIcon"; | |
| import GoalAvatar from "../GoalAvatar"; | |
| import GoalTitle from "./components/GoalTitle"; | |
| import { GoalContainer } from "../ZItemContainer"; | |
| import GoalIcon from "./components/GoalIcon"; | |
| import NotificationSymbol from "@src/common/NotificationSymbol"; | |
| import CopyIcon from "@src/assets/CopyIcon"; |
src/helpers/Contacts.tsx
Outdated
| @@ -0,0 +1,50 @@ | |||
| import GoalIcon from "@components/GoalsComponents/MyGoal/components/GoalIcon"; | |||
There was a problem hiding this comment.
🚫 [eslint] <import/no-named-as-default> reported by reviewdog 🐶
Using exported name 'GoalIcon' as identifier for default export.
src/helpers/Contacts.tsx
Outdated
| contact: ContactItem; | ||
| setSelectedContact: Dispatch<SetStateAction<ContactItem | null>>; | ||
| }) => { | ||
| const [expandGoalId, setExpandGoalId] = useState("root"); |
There was a problem hiding this comment.
'setExpandGoalId' is assigned a value but never used.
src/helpers/Contacts.tsx
Outdated
| }) => { | ||
| const [expandGoalId, setExpandGoalId] = useState("root"); | ||
|
|
||
| const [isAnimating, setIsAnimating] = useState(true); |
There was a problem hiding this comment.
'setIsAnimating' is assigned a value but never used.
src/pages/GoalsPage/ContactsPage.tsx
Outdated
| const { partnersList } = usePartnerContext(); | ||
|
|
||
| return ( | ||
| <AppLayout title="contacts" debounceSearch={() => {}}> |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-empty-function> reported by reviewdog 🐶
Unexpected empty arrow function.
|
@tijlleenders what should happen on receiver side when a contact is deleted by a user? |
Interesting question... I see three possible reasons for deleting a contact(device):
Only in the last case there is a reason to:
For now, let's not add any extra requirements. |
Resolves #1790