Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid downloading carto uri remote resources that are within commented code #74

Open
springmeyer opened this issue Sep 20, 2012 · 2 comments

Comments

@springmeyer
Copy link
Member

We use regex magic to find carto uris needing downloaded/localized. Doing this before carto means that we have no reasonable way to know if the code is commented with // or /* code */. So we will end up downloading stuff that is not active, which is wasteful and could lead to odd behavior since data is cached.

Not sure about ways to avoid this however, without creating a dependency on carto, or moving the localization code back into carto, which would not be ideal (because it's nice to keep all this dodgy code in one place).

@springmeyer
Copy link
Member Author

Looked into using carto.Parser({}).parse(s.data).toList({}) to try to pull out valid uris' but I'm a bit lost on the best way to iterate the result of that call. Will pick back up tomorrow.

@tmcw
Copy link
Contributor

tmcw commented Sep 29, 2012

The best way to do this (afaik) is to use effects to build a list; it's how we push around variables and such. I'll take a look at this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants