You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use regex magic to find carto uris needing downloaded/localized. Doing this before carto means that we have no reasonable way to know if the code is commented with // or /* code */. So we will end up downloading stuff that is not active, which is wasteful and could lead to odd behavior since data is cached.
Not sure about ways to avoid this however, without creating a dependency on carto, or moving the localization code back into carto, which would not be ideal (because it's nice to keep all this dodgy code in one place).
The text was updated successfully, but these errors were encountered:
Looked into using carto.Parser({}).parse(s.data).toList({}) to try to pull out valid uris' but I'm a bit lost on the best way to iterate the result of that call. Will pick back up tomorrow.
We use regex magic to find carto uris needing downloaded/localized. Doing this before carto means that we have no reasonable way to know if the code is commented with
//
or/* code */
. So we will end up downloading stuff that is not active, which is wasteful and could lead to odd behavior since data is cached.Not sure about ways to avoid this however, without creating a dependency on carto, or moving the localization code back into carto, which would not be ideal (because it's nice to keep all this dodgy code in one place).
The text was updated successfully, but these errors were encountered: