web: classify cmdimage logs as build logs (#6418)

fixes #6415 Signed-off-by: Nick Santos <nick.santos@docker.com>
tilt-dev · Jul 30, 2024 · c0e12e3 · c0e12e3
1 parent a80ab61
commit c0e12e3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/web/src/OverviewLogPane.tsx b/web/src/OverviewLogPane.tsx
@@ -16,6 +16,7 @@ import LogStore, {
   LogUpdateEvent,
   useLogStore,
 } from "./LogStore"
+import { isBuildSpanId } from "./logs"
 import PathBuilder, { usePathBuilder } from "./PathBuilder"
 import { RafContext, useRaf } from "./raf"
 import { useStarredResources } from "./StarredResourcesContext"
@@ -449,13 +450,10 @@ export class OverviewLogComponent extends Component<OverviewLogComponentProps> {
     }
 
     let source = this.props.filterSet.source
-    if (
-      source === FilterSource.runtime &&
-      line.spanId.indexOf("build:") === 0
-    ) {
+    if (source === FilterSource.runtime && isBuildSpanId(line.spanId)) {
       return false
     }
-    if (source === FilterSource.build && line.spanId.indexOf("build:") !== 0) {
+    if (source === FilterSource.build && !isBuildSpanId(line.spanId)) {
       return false
     }
 

diff --git a/web/src/logs.ts b/web/src/logs.ts
@@ -48,5 +48,5 @@ export function sourcePrefix(n: string) {
 }
 
 export function isBuildSpanId(spanId: string): boolean {
-  return spanId.indexOf("build:") !== -1
+  return spanId.indexOf("build:") === 0 || spanId.indexOf("cmdimage:") === 0
 }