BLD: Use scikit-build for Python packaging #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setuptools isn't designed for CMake projects. scikit-build is. It's even designed to use already installed CMake and Ninja if available.
keywords copied from GitHub keywords. classifiers inspired by that list.
I didn't actually change anything in the CMakeFile, so the old version should still work.
|
Thank you for your submission! Before merging this, I need to test how well it integrates with the build pipeline (.github/workflows/wheels.yml) and if it need modification |
|
Seems to integrate well, lets merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scikit-build (technically the rewrite scikit-build-core) is built on CMake, which would seem to mesh well with the rest of the project. This also gets the python bindings built on my platform.
Building the python packages changes from
python setup.py sdist bdist_wheeltopython -m build ., thoughpython -m pip install .will still work fine.