Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for use by other plugins #209

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

jonathanvanschenck
Copy link
Contributor

@jonathanvanschenck jonathanvanschenck commented Jul 9, 2024

This adds a globally accessible object which exposes the internal verse fetching/rendering functionality for use by other plugins.

I should mention, I don't feel strongly about the names of anything here, please feel free to critique and I'm happy to adapt!

@jonathanvanschenck
Copy link
Contributor Author

It is allow worth noting, there is a current work around to accomplish this same task, however, it doesn't allow mutating the configuration (i.e. you can't pick an alternative version)

(await window.app.plugins.plugins["obsidian-bible-reference"].verseLookUpModal.getSuggestions("John 3:16"))[0]?.allFormattedContent)

@tim-hub tim-hub self-requested a review July 11, 2024 19:34
@tim-hub
Copy link
Owner

tim-hub commented Jul 17, 2024

Thanks

@tim-hub tim-hub merged commit b612fe4 into tim-hub:master Jul 17, 2024
2 checks passed
@tim-hub
Copy link
Owner

tim-hub commented Jul 17, 2024

@all-contributors please add @jonathanvanschenck for code

Copy link
Contributor

@tim-hub

@jonathanvanschenck already contributed before to code

@jonathanvanschenck
Copy link
Contributor Author

Actually this is my first time contributing -- I had added myself to the the contributorsrc as one of the commits, but it appears that I forgot to update the readme too -- apologies

@jonathanvanschenck jonathanvanschenck deleted the feature/add-api branch November 22, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants