Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify alternate version #242

Merged

Conversation

Benedictteo05
Copy link
Contributor

Usage

--matt1:1-esv
--matt1:1-niv2011

Added regex to match the versions.
Created a constant defaultBibleVersion to fall back on if the specified version is not in BibleVersionCollection.

@tim-hub tim-hub self-requested a review December 5, 2024 01:37
@tim-hub tim-hub self-assigned this Dec 5, 2024
@tim-hub
Copy link
Owner

tim-hub commented Dec 5, 2024

I tried to read and codes and understand it.

Just a quick question, what will it happen if I type --matt1:1 instead of --matt1:1-esv? @Benedictteo05

@Benedictteo05
Copy link
Contributor Author

If we use --matt1:1 the regex won't be matched, so it'll act as how it currently will.

Copy link
Owner

@tim-hub tim-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tim-hub tim-hub merged commit 5bfb00d into tim-hub:master Dec 5, 2024
2 checks passed
@tim-hub
Copy link
Owner

tim-hub commented Dec 5, 2024

@allcontributors add @Benedictteo05 for code

Copy link
Contributor

@tim-hub

I've put up a pull request to add @Benedictteo05! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants