2.x Fix tests #142
2.x Fix tests #142
Conversation
gchtr
commented
Jul 31, 2023
•
gchtr
commented
- Fix tests by using GitHub Actions instead of Travic CI.
- Fix Issue with 2.0 theme after most recent folder restructuring #141.
Co-authored-by: Viktor Szépe <viktor@szepe.net>
.github/workflows/test.yml
Outdated
| # PHP 8.1 | ||
| - php: '8.1' | ||
| wp: 'latest' | ||
| dependency-version: 'prefer-stable' |
There was a problem hiding this comment.
Only lowest/locked/highest.
We don't have a lock file, so "locked" is out.
Using prefer-stable/lowest is a popular myth. Please see https://gist.github.com/szepeviktor/200b45f9805dc8bf3f185f0ade216987
There was a problem hiding this comment.
The way I see it, we could just remove dependency-version all together in the workflow and let Composer decide, right? For the starter theme, we only need to test against the latest versions, because what it’s going to b used with.
There was a problem hiding this comment.
we only need to test against the latest versions
And we don't have other versions :)
Testing with lowest versions will reveal problems in the long-term.
https://github.com/szepeviktor/byte-level-care/blob/a1cf6cc74a7b98deb28ff5b97feec9784a45be29/.github/workflows/back-end.yml#L84-L89
I see that every month 👁️
There was a problem hiding this comment.
Updated in 244d315 (#142).
Co-authored-by: Viktor Szépe <viktor@szepe.net>
