Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Starter Theme for 2.x #1784

Closed
2 tasks
jarednova opened this issue Sep 10, 2018 · 5 comments
Closed
2 tasks

Update Starter Theme for 2.x #1784

jarednova opened this issue Sep 10, 2018 · 5 comments

Comments

@jarednova
Copy link
Member

jarednova commented Sep 10, 2018

  • Ensure calls to all Timber classes are namespaced
  • Ensure there are no deprecation warnings from any methods/classes called
@marciojc
Copy link
Contributor

Hi,
I did some improves, timber/starter-theme#72.

@jarednova
Copy link
Member Author

Awesome, thanks @marciojc ! I'll check them out in the next few days

@jarednova jarednova changed the title Update Starter Theme Update Starter Theme for 2.x Sep 25, 2018
@jarednova
Copy link
Member Author

Thanks again @marciojc — I've now merged your changes into the starter theme. I'm going to leave this issue open as we work to get the starter theme to use the new 2.x syntax and classes

@marciojc
Copy link
Contributor

Thanks @jarednova. I will continue working on updating the starter theme when possible.

@gchtr
Copy link
Member

gchtr commented Jul 31, 2023

With the updates in timber/starter-theme#142, I think we can close this.

@gchtr gchtr closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants