Non-substantive changes per recommendations #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup-node v3 > v4
Date() > Date(Date.now())
michmich > magicmirror
eslint-plugin-json > eslint-plugin-jsonc
KristjanESPERANTO
suggested changes
Mar 25, 2024
package.json
Outdated
| @@ -21,7 +21,7 @@ | |||
| "eslint-config-airbnb-base": "^15.0.0", | |||
| "eslint-config-prettier": "^9.0.0", | |||
| "eslint-plugin-import": "^2.29.0", | |||
| "eslint-plugin-json": "^3.1.0", | |||
| "eslint-plugin-jsonc": "^2.14.1", | |||
There was a problem hiding this comment.
Replacing the plugin is a good thing, but would also require a change in the ESLint configuration.
I see two options here:
- adjust the ESLint configuration accordingly. Or
- undo the change and we address this in a new PR. As I also like and use this module, I am quite willing to do this 🙂
|
I'll close and let you deal with ESLint. Once you have the ESLint tutorial up, I may try to tackle it. But I'm not very good with javascript, so I definitely don't know how to check it with ESLint. |
This reverts commit 4a34413.
|
Reopening with the jsonc change backed out. The others should be fine. |
KristjanESPERANTO
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-JsonTable-by-timdows
I have tested this, though I'm not sure my non-dev production installation is using
eslint-plugin-json, which is changed toeslint-plugin-jsonc(latest version per the documentation I found) in this PR.They also recommend creating a "flat" eslint config, which I know nothing about,
and changing the primary branch name to.main, which I can't do in a PRUpdate: I don't recommend changing the branch name as it will mess with
git pull