Dependency maintenance #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AaronMoat
commented
Jan 7, 2024
AaronMoat
commented
- Upgrade everything including node (required by commander upgrade)
- Swap del for rimraf, as del is ESM only and old versions have vulnerabilities (e.g. via https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116).
- Fix bug with unions resulting in infinite recursion except for depthLimit. I came across this while manually testing the changes here in one of my repos - I think it was an unintended consequence of fix: Correct display of union child, fix empty braces when no fields on selected deep #44, and the test introduced in that PR still passes, so I think my small change here is likely ok?
- Upgrade everything - Swap del for rimraf, as del is ESM only and old versions have vulnerabilities (e.g. via https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116). - Fix bug with unions resulting in infinite recursion except for depthLimit. I came across this while manually testing the changes here in one of my repos - I think it was an unintended consequence of #44, and the test introduced in that PR still passes, so I think my small change here is likely ok?
AaronMoat
commented
Jan 7, 2024
|
|
||
| function main ({ | ||
| function main({ |
There was a problem hiding this comment.
All formatting changes were done by eslint upgrades and running lint --fix.
| @@ -108,19 +108,25 @@ function main ({ | |||
| ) { | |||
| return ''; | |||
| } | |||
| if (!fromUnion) { | |||
There was a problem hiding this comment.
This is the bug fix I mentioned.
|
Hey @timqian, just giving a ping as I don't have permission to 'request reviewer' on this fork :) |
|
@AaronMoat Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.